Update focal to use gcc9

[mjcarroll]

Signed-off-by: Michael Carroll [email protected]

[chapulina]

I believe the test run in gazebosim/gz-fuel-tools#230 didn't have coverage enabled, it would be nice to test that LCOV is working as expected with this change

[scpeters]

this is needed for jammy

https://github.com/ignitionrobotics/sdformat/runs/5858181025?check_suite_focus=true

[chapulina]

Has anyone triggered a test run using this branch which has coverage enabled? I just wanna make sure we don't break the coverage jobs

[scpeters]

Has anyone triggered a test run using this branch which has coverage enabled? I just wanna make sure we don't break the coverage jobs

trying it now with gazebosim/gz-math@1f6703c

• https://github.com/ignitionrobotics/ign-math/runs/5862490338?check_suite_focus=true

[chapulina]

The test run was successful!

[azeey]

Coverage seems to be broken in some (if not all) our libraries. In sdformat PR #939, for example, the number of tracked files is now just 2:

whereas, about a month ago (eg gazebosim/sdformat#909), the number of files was 69:

I suspect removing the lcov related lines might have caused the issue, but I'm not 100% sure.

[scpeters]

Has anyone triggered a test run using this branch which has coverage enabled? I just wanna make sure we don't break the coverage jobs

trying it now with ignitionrobotics/ign-math@1f6703c

• https://github.com/ignitionrobotics/ign-math/runs/5862490338?check_suite_focus=true

it looks like the GitHub action didn't passed the status check but didn't generate a proper coverage report

• https://app.codecov.io/gh/ignitionrobotics/ign-math/branch/scpeters%2Faction_focal_gcc9

[azeey]

it looks like the GitHub action didn't passed the status check but didn't generate a proper coverage report

https://app.codecov.io/gh/ignitionrobotics/ign-math/branch/scpeters%2Faction_focal_gcc9

That actually looks okay to me (https://codecov.io/gh/ignitionrobotics/ign-math/tree/1f6703cd08f2c4685ae1c0b3ecddb5df1a300841). The project totals show 70 files, which is 2 more than a random PR I picked from 2 moths ago.

[azeey]

Okay, this might actually be caused by the Checkout action due to actions/checkout#764. I think what's happening is that codecov tries to determine the project root using git (https://github.com/codecov/codecov-bash/blob/1817ab23d6b35ff6596e48d15db366b71f17ada3/codecov#L48), but fails due to how the repo is checkout as of actions/checkout#764. We can see this when comparing the console output of codecov for a failed and successful report generation:

Failed report generation (https://github.com/ignitionrobotics/sdformat/runs/6244787092?check_suite_focus=true)

  current dir:  /github/workspace/build
  project root: .

Successful report generation (https://github.com/ignitionrobotics/sdformat/runs/5565309483?check_suite_focus=true)

  current dir:  /github/workspace/build
  project root: /github/workspace

My suggestion would be to cd into the root and run codecov from there with a flag to tell it where to find the coverage.info file.