Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Context, Failure, Formatter types #71

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Add Context, Failure, Formatter types #71

merged 3 commits into from
Jun 5, 2020

Conversation

goku321
Copy link
Contributor

@goku321 goku321 commented Apr 16, 2020

Added following types:

  1. Context struct
  2. Failure struct
  3. Formatter interface

Fixes: #69

@goku321 goku321 changed the title Add context failure formatter Add Context, formatter Apr 16, 2020
@goku321 goku321 changed the title Add Context, formatter Add Context, Failure, Formatter types Apr 16, 2020
@coveralls
Copy link
Collaborator

coveralls commented Apr 16, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 93.955% when pulling 7845739 on goku321:add-context-failure-formatter into 4cfa969 on gavv:master.

@gavv
Copy link
Owner

gavv commented Jun 3, 2020

Thanks a lot for your PR and sorry for huge delay. I'll review it in upcoming days.

@gavv gavv added the ready for review Pull request can be reviewed label Jun 3, 2020
@gavv gavv added this to the v2 milestone Jun 3, 2020
@gavv gavv changed the base branch from master to context June 5, 2020 06:53
@gavv gavv merged commit e54eb9d into gavv:context Jun 5, 2020
@gavv
Copy link
Owner

gavv commented Jun 5, 2020

LGTM!

Since we'll have multiple PRs, I created a feature branch for this issue (named context):

https://github.com/gavv/httpexpect/commits/context

We'll merge related PRs into it, and when the feature is done, I'll merge context into master.

@gavv gavv removed the ready for review Pull request can be reviewed label Jun 5, 2020
@gavv gavv mentioned this pull request Feb 20, 2021
Closed
gavv pushed a commit that referenced this pull request Jul 20, 2021
@goku321 @gavv
Add Context, Failure, Formatter types (#71)
8c3fbb3 
added context, failure & formatter types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.

Rework error reporting and formatting
3 participants
@goku321 @coveralls @gavv