Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Environment.Clear method #300

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Add Environment.Clear method #300

merged 6 commits into from
Feb 23, 2023

Conversation

e-berman
Copy link
Contributor

@e-berman e-berman commented Feb 20, 2023 •
edited
Loading

PR addresses the following issue #260

Any change recommendations or best practice tips are greatly appreciated.

@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2023 •
edited
Loading

Coverage Status

Coverage: 95.07% (+0.005%) from 95.065% when pulling cc2b260 on e-berman:eberman_clear_method into c5c63ce on gavv:master.

@e-berman e-berman marked this pull request as ready for review February 20, 2023 18:23
@gavv gavv added the ready for review Pull request can be reviewed label Feb 21, 2023
gavv
gavv reviewed Feb 22, 2023
View reviewed changes
Copy link
Owner

@gavv gavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! A few comments.

environment.go Outdated Show resolved Hide resolved
environment.go Outdated Show resolved Hide resolved
environment_test.go Outdated Show resolved Hide resolved
@gavv gavv added needs revision Pull request should be revised by its author and removed ready for review Pull request can be reviewed labels Feb 22, 2023
@gavv gavv linked an issue Feb 22, 2023 that may be closed by this pull request
Add Environment.Clear #260
Closed
@gavv gavv merged commit f3f851f into gavv:master Feb 23, 2023
@gavv
Copy link
Owner

gavv commented Feb 23, 2023

LGTM!

@gavv gavv removed the needs revision Pull request should be revised by its author label Feb 23, 2023
@e-berman e-berman deleted the eberman_clear_method branch February 23, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavv gavv gavv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Environment.Clear
3 participants
@e-berman @coveralls @gavv