Modified chain.leave() to handle concurrency #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gavv could you take a look at this? I'll move towards adding test cases if It looks good.
|
|
The patch looks good now, thanks! We also need the test for chain discussed in previous PR. |
|
Oh, you already mentioned the test. Cool, thanks. |
gavv
reviewed
Feb 6, 2023
gavv
changed the title
Rohith-Raju
force-pushed
the
Deadlock_resolver
branch
from
50155aa to
49ea774
Compare
|
@gavv the tests are a rough sketch. |
|
LGTM |
Rohith-Raju
force-pushed
the
Deadlock_resolver
branch
from
a5ebdc6 to
7915828
Compare
|
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
github-actions
bot
added
the
needs rebase
Signed-off-by: ROHITH RAJU <[email protected]>
Signed-off-by: ROHITH RAJU <[email protected]>
Signed-off-by: ROHITH RAJU <[email protected]>
gavv
force-pushed
the
Deadlock_resolver
branch
from
7915828 to
58f6486
Compare
gavv
removed
work in progress
|
Thanks. I've rebased PR on fresh master and added a few cosmetic fixes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ROHITH RAJU [email protected]
Merge this to #254 to make
environmentthread-safe.