Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PanicReporter #248

Closed
gavv opened this issue Jan 28, 2023 · 0 comments · Fixed by #341
Closed

Implement PanicReporter #248

gavv opened this issue Jan 28, 2023 · 0 comments · Fixed by #341
Labels
feature New feature or request good first issue Good for newcomers help wanted Contributions are welcome
Milestone
v2

Comments

@gavv
Copy link
Owner

gavv commented Jan 28, 2023

See #187 for details. PanicReporter will be similar to FatalReporter, but instead of calling t.Fatalf, it just calls panic.

This reporter may be useful in multithreaded tests because t.Fatal may be called only from test's goroutine. This should be mentioned in the comment.
@gavv gavv added feature New feature or request help wanted Contributions are welcome good first issue Good for newcomers labels Jan 28, 2023
Dev-29 added a commit to Dev-29/httpexpect that referenced this issue Feb 28, 2023
@Dev-29
Implemented: PanicReporter (gavv#248)
aa5b41b
@Dev-29 Dev-29 mentioned this issue Feb 28, 2023
Closed
@a-camarillo a-camarillo mentioned this issue Mar 21, 2023
Merged
@gavv gavv closed this as completed in #341 Mar 22, 2023
@gavv gavv added this to the v2 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue Good for newcomers help wanted Contributions are welcome
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

PanicReporter implementation a-camarillo/httpexpect
1 participant
@gavv