-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluating parametric terms with factor by-variable #68
Comments
There's a bug here somewhere (either by design or by problem with the code). I'll take a look. Thanks for letting me know. |
@Excidion I figured out what the issue was but fixing this means you won't be able to do what you wanted with the form of interaction. R treats You could achieve what you want using I'd welcome some input on what you would like to have happen if I could literally return the contribution to the fitted model for the
The other option, which would be a departure from what Thoughts on what behaviour you were expecting? |
I am definitely more fond of returning the contributions to the fitted model. This is, at least for me, closer to some of the core aspects why i value GAM models - the intuitive interpretability of their results. On how to handle the entries of the Hope I picked up on your questions in the right way and my answers can be helpful. |
Am going to close this; I will circle back to the issue of plotting contributions from interactions if I decide to add this capability to gratia |
When calling
evaluate_parametric_term
on a a term of two factor variables, the information on wich values belongs to which combination seems to get lost.Imagine a
model
with a formula that includesy~factorvar1:factorvar2
. When callingthe resulting table contains no information on which row belongs to which combination of levels of the factors. The column
"term"
only contains the entry"factorvar1:factorvar2"
in every row.Also the table has the same number of rows as my dataset, which is not the behavior of
evaluate_parametric_term
orevaluate_smooth
that I am used to.Am I missing something or have I been interpreting the purpose of these functions wrong? Or is this indeed a bug?
The text was updated successfully, but these errors were encountered: