Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The colour scale is off in at least TPRS and tensor product smooths for 2d smooths #193

Closed
gavinsimpson opened this issue Oct 13, 2022 · 1 comment
Closed

The colour scale is off in at least TPRS and tensor product smooths for 2d smooths #193

gavinsimpson opened this issue Oct 13, 2022 · 1 comment
Labels
bug Something isn't working plotting
Milestone
0.8

Comments

@gavinsimpson
Copy link
Owner

See the brain example from the Physalia course as an example of the problem
@gavinsimpson gavinsimpson added bug Something isn't working plotting labels Oct 13, 2022
@gavinsimpson gavinsimpson added this to the 0.8 milestone Oct 13, 2022
@gavinsimpson
Copy link
Owner Author

This happens when we set some response data to NA where it lies too far from the support of the data. This ends up creating an invalid range which ggplot seemingly rejects. Fix to remove NA when computing the maximum of the absolute values of the response for the scale.

gavinsimpson added a commit that referenced this issue Oct 19, 2022
@gavinsimpson
update a test that changes due to #193
420033e
gavinsimpson added a commit that referenced this issue Oct 19, 2022
@gavinsimpson
bump version and document #193
81cd646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working plotting
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
1 participant
@gavinsimpson