Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apply_only argument. Add force_conflicts option. #148

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Jan 12, 2022

https://docs.aws.amazon.com/eks/latest/userguide/add-user-role.html

Some cloud providers have resources such as aws-auth configmap that can be applied but never deleted permanently.
It would be smart to handle such cases as well.

@kahirokunn kahirokunn changed the title add apply_only argument Add apply_only argument Jan 12, 2022
@kahirokunn kahirokunn changed the title Add apply_only argument Add apply_only argument. Add force_conflicts option. Jan 13, 2022
@stevehipwell
Copy link

@kahirokunn what about also being able to define the field manager name?

Copy link
Owner

@gavinbunney gavinbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gavinbunney gavinbunney merged commit 16f7be2 into gavinbunney:master Jan 13, 2022
@aidanmelen
Copy link

@gavinbunney when do you think this will get released to terraform registry?

@@ -42,6 +42,8 @@ YAML
* `sensitive_fields` - Optional. List of fields (dot-syntax) which are sensitive and should be obfuscated in output. Defaults to `["data"]` for Secrets.
* `force_new` - Optional. Forces delete & create of resources if the `yaml_body` changes. Default `false`.
* `server_side_apply` - Optional. Allow using server-side-apply method. Default `false`.
* `force_conflicts` - Optional. Allow using force_conflicts. Default `false`.
* `apply_only` - Optional. It does not delete resource in any case Default `false`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ Default/. Default/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants