forked from angular/material
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
e4b4ecf
commit 4abadf1
Showing
1 changed file
with
46 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
## Understanding the Team Commit Process | ||
|
||
The Angular Material team has a very specific process for change commits. | ||
|
||
Our commit process is intentionally restrictive to support the rapid iterations and manage change complexity within Angular Material. Angular Material uses a "Pull Request" process to allow team leaders opportunities to maintain code reviews, ensure sanity checks, encourage coding standards, and provide feedbackto the developer. | ||
|
||
#### General Rules | ||
|
||
* Please **do not** commit directly to master; unless explicitly authorized by the Team Leadership | ||
* Team developers should fork the repository and work on fixes, features, or enhancements on their own fork. | ||
* Use the Pull Request feature to submit your changes to the 'upstream' Angular Material repository | ||
* When a developer has changes ready for merging into master, those fixes or updates must be submitted via a Pull Request | ||
* All PRs must be rebased (with master) and commits squashed prior to the final merge process | ||
* Please **NEVER** use the *green* merge button on GitHub | ||
* Angular Material maintains a *flat*, linear change history using a specific **manual merge process** | ||
* Do not use Github's automated merge process | ||
* All PR source (component or core) changes should have accompanying unit tests | ||
* All PRs must have 100% Karma test scores | ||
|
||
> These process guidelines are especially important: our team membership is growing rapidly. | ||
#### Commit Authorization Rules | ||
|
||
The development team has defined three (3) Github levels of **commit authorization** within [Angular/Material](https://github.com/angular/material/): | ||
|
||
* General : | ||
* Developers in this group includes any team members not listed under Core or Team Leads below | ||
* Must use Angular Materila Forked repositories for any and all changes (see above) | ||
* Please do not make or submit any changes from the master branch. | ||
* Are not authorized to merge PRs | ||
* Should not reassign issue or change issue milestones | ||
* Should ensure their issue labels are correct | ||
* Should ensure their issues are tested with latest HEAD versions of Angular Material | ||
* Should ensure their issues are tested with latest releases of Angular (1.3.x, 1.4.x, 1.5.x) | ||
* Core: | ||
* Includes: [Ryan Schmukler](@rschmukler), [Robert Messerlee](@robertmesserle), [Topher Fangio](@topherfangio) | ||
* Should not merge PRs (unless explicitly requested) | ||
* Should use Angular Material branches for major, non-trivial changes. | ||
* For minor changes, developers in this groupmay elect to commit direct to master for minor changes. | ||
* Team Leads: | ||
* Includes: [Naomi Black](@naomiblack), [Thomas Burleson](@thomasburleson), [Jeremy Elbourn](@jelbourn) | ||
* May review PRs | ||
* ThomasBurleson is the primary PR reviewer | ||
* Should perform confirm Karma test pass | ||
* Should squash as need | ||
* Should ensure the PR is closed when the merge finishes. |