Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max depth #26

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Add max depth #26

merged 3 commits into from
Apr 3, 2020

Conversation

dholbach
Copy link
Contributor

@dholbach dholbach commented Apr 1, 2020

In this PR I

  • add the option to pass max-depth to allow specifying how deep to search for markdown files (in our case, I wanted just the markdown files at the top level)
  • took the liberty of deduplicating entrypoint.sh somewhat

Let me know what you think. :-)

@ghost
Copy link

ghost commented Apr 1, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.371 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

dholbach pushed a commit to fluxcd/flux that referenced this pull request Apr 1, 2020
	- .github/workflows/markdown-link-check-config.json has some
	  patterns we exlude while checking the markdown files in the
	  top-level directories (company websites on README.md and
	  billions of GH issues in CHANGELOG.md in particular)
	- once gaurav-nelson/github-action-markdown-link-check#26
	  is merged, we can move back to the official GH Action
entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Outdated Show resolved Hide resolved
@gaurav-nelson
Copy link
Owner

gaurav-nelson commented Apr 2, 2020

Thanks @dholbach for the PR. Changes work as expected.

Can we use some alternate command instead of using eval? I was trying to run it as array, please feel free to update #29

@gaurav-nelson gaurav-nelson changed the base branch from master to develop April 2, 2020 03:40
@gaurav-nelson
Copy link
Owner

Thanks @dholbach again for the PR, there are some issues which I will fix before release.

@gaurav-nelson gaurav-nelson merged commit 2e71dce into gaurav-nelson:develop Apr 3, 2020
dholbach pushed a commit to fluxcd/flux that referenced this pull request Apr 3, 2020
	- .github/workflows/markdown-link-check-config.json has some
	  patterns we exlude while checking the markdown files in the
	  top-level directories (company websites on README.md and
	  billions of GH issues in CHANGELOG.md in particular)
	- once gaurav-nelson/github-action-markdown-link-check#26
	  is merged, we can move back to the official GH Action
@dholbach dholbach deleted the add-max-depth branch April 3, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants