-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript versions of the homepage starters #95
Merged
aghreed
merged 30 commits into
main
from
aghreed/sc-47188/spike-add-a-ts-variation-to-the-homepage
Mar 28, 2022
Merged
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7f36c25
setup to use tsc
aghreed f16f915
working initial pass on transpilation within publish script
aghreed 25ffa94
adjust data.js content and publish script to accommodate only running…
aghreed 50ab14d
convert ui.js to ui.tsx - update all .css.ts imports to explicitly us…
aghreed 091db7d
convert over all the src/components to ts
aghreed 7b32ace
wip converting pages to tsx
aghreed 477c60e
fix logic in publish script
aghreed d246222
remove .ts file extension from import of vanilla-extract files - upda…
aghreed 111f7af
updates after self-review
aghreed 97e0750
use more types in components
aghreed 80c7413
merge in work from components branch
aghreed 25ca6ce
convert pages to TS and flesh out sections.tsx functionality
aghreed e7eef40
resolve newline issue during transpilation with code comments
aghreed 6add91f
update publish script and data file
aghreed 222a545
use union types of string literals rather than enums
aghreed 513d184
Merge pull request #97 from gatsbyjs/chore/ts-pages-components
aghreed db1d92a
revert to old sections component implementation but with types
aghreed db9829b
remove unused type
aghreed 8f9d74a
tweak publish script for TS concerns
aghreed 2e75135
add yarn.lock file to list of files copied over in publish to ensure …
aghreed e43d532
support the TS flavors of the READMEs and handle renaming in publish …
aghreed 293707b
merge in main
aghreed efb2de8
adjust publish script to remove about.tsx from ts wordpress starter
aghreed 1c89da1
add deleted array to checks for when to commit in publish script
aghreed 103cc7d
remove strict mode flag - update per PR feedback
aghreed e8040ea
update how fileExt in inline code are replaced in READMEs - rephrase …
aghreed 04eb709
merge in latest from main
aghreed c15a69f
re-add Fallback component for when blocktype does not match a component
aghreed 2511ce8
tweaks to publish script
aghreed dd924ff
update note on TS and JS versions
aghreed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we use the
size
prop at all; I'd be keen to remove it to simplify the API a little