Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed change for #6512 #6535

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Proposed change for #6512 #6535

merged 1 commit into from
Jul 20, 2018

Conversation

steoneill
Copy link
Contributor

@steoneill steoneill commented Jul 18, 2018

Fixes #6512

@KyleAMathews
Copy link
Contributor

Deploy preview for using-postcss-sass failed.

Built with commit 16affbd

https://app.netlify.com/sites/using-postcss-sass/deploys/5b4f6540b13fb111c3599753

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 16affbd

https://deploy-preview-6535--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 16affbd

https://deploy-preview-6535--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Deploy preview for gatsbyjs failed.

Built with commit 16affbd

https://app.netlify.com/sites/gatsbyjs/deploys/5b4f653fb13fb111c359974b

@m-allanson
Copy link
Contributor

Thanks @steoneill! The preview builds aren't working at the moment, could you add a screenshot that shows your change?

@steoneill
Copy link
Contributor Author

screen shot 2018-07-20 at 14 05 45

Hi there @m-allanson , screenshot above!

I've just moved the button away from the Showcase button to allow both to be used properly :)

@m-allanson
Copy link
Contributor

Thanks :) cc @fk

Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @steoneill!

@steoneill
Copy link
Contributor Author

@fk no problem :) Glad to help!

@m-allanson m-allanson merged commit a49f240 into gatsbyjs:master Jul 20, 2018
@gatsbot
Copy link

gatsbot bot commented Jul 20, 2018

Holy buckets, @steoneill — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants