Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update createPage documentation w/ Content Sync #33848

Merged
merged 6 commits into from
Nov 8, 2021

Conversation

kathmbeck
Copy link
Contributor

@kathmbeck kathmbeck commented Nov 3, 2021

Description

Update createPages documentation to reflect use of the ownerNodeId parameter for content sync.
Approval requires #33866 to be merged first.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 3, 2021
@kathmbeck kathmbeck requested review from a team and TylerBarnes November 3, 2021 21:49
@pvorozhe pvorozhe removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 3, 2021
@aghreed
Copy link
Contributor

aghreed commented Nov 3, 2021

That failing cloud test check is the only thing stopping me from approving here. Might be worth an ole re-run.

Also, not sure if it's documented anywhere, but I've noticed a convention of prefixing PR titles that update does with "chore(docs)" and slapping on the "type: documentation" label just to help categorize / organize PRs in this repo

@TylerBarnes
Copy link
Contributor

TylerBarnes commented Nov 3, 2021

@aghreed that PR title pattern is called conventional commits. It's pretty sweet 😄 @kathmbeck I'll review this in the AM, gotta head out for the night right now

Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few wording changes 😄

@TylerBarnes TylerBarnes changed the title updated createPage documentation for use with Content Sync docs: updated createPage documentation for use with Content Sync Nov 5, 2021
@LekoArts LekoArts changed the title docs: updated createPage documentation for use with Content Sync chore(docs): Update createPage documentation w/ Content Sync Nov 5, 2021
@wardpeet wardpeet requested a review from LekoArts November 8, 2021 08:09
@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Nov 8, 2021
@LekoArts LekoArts merged commit ae17254 into master Nov 8, 2021
@LekoArts LekoArts deleted the ownerNodeId-docs branch November 8, 2021 08:58
axe312ger pushed a commit that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants