-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Update createPage
documentation w/ Content Sync
#33848
Conversation
That failing cloud test check is the only thing stopping me from approving here. Might be worth an ole re-run. Also, not sure if it's documented anywhere, but I've noticed a convention of prefixing PR titles that update does with "chore(docs)" and slapping on the "type: documentation" label just to help categorize / organize PRs in this repo |
@aghreed that PR title pattern is called conventional commits. It's pretty sweet 😄 @kathmbeck I'll review this in the AM, gotta head out for the night right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few wording changes 😄
createPage
documentation w/ Content Sync
Co-authored-by: Lennart <[email protected]>
Description
Update createPages documentation to reflect use of the ownerNodeId parameter for content sync.
Approval requires #33866 to be merged first.
Documentation
Related Issues