Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-contentful): Add node manifest support for previews #33297

Merged
merged 28 commits into from
Oct 13, 2021

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Sep 23, 2021

This PR adds support to gatsby-source-contentful for the upcoming Content Sync preview on Gatsby Cloud. Content Sync handles loading state, errors, and redirection to preview content for preview builds.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 23, 2021
@TylerBarnes TylerBarnes changed the title feat(contentful): Add node manifest support for previews feat(gatsby-source-contentful): Add node manifest support for previews Sep 23, 2021
@TylerBarnes TylerBarnes marked this pull request as ready for review October 12, 2021 22:13
@TylerBarnes TylerBarnes added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 12, 2021
pvorozhe
pvorozhe previously approved these changes Oct 12, 2021
Copy link
Contributor

@pvorozhe pvorozhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like tests are flaky.

@TylerBarnes
Copy link
Contributor Author

Looks like the failing tests are unrelated, gonna merge.

@TylerBarnes TylerBarnes merged commit 3a385a5 into master Oct 13, 2021
@TylerBarnes TylerBarnes deleted the feat/add-contentful-node-manifest branch October 13, 2021 21:43
vladar pushed a commit that referenced this pull request Oct 14, 2021
#33297)

(cherry picked from commit 3a385a5)

# Conflicts:
#	packages/gatsby-source-contentful/src/normalize.js
#	packages/gatsby-source-contentful/src/source-nodes.js
vladar added a commit that referenced this pull request Oct 15, 2021
#33297) (#33531)

(cherry picked from commit 3a385a5)

# Conflicts:
#	packages/gatsby-source-contentful/src/normalize.js
#	packages/gatsby-source-contentful/src/source-nodes.js

Co-authored-by: Tyler Barnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants