-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby): enable async rendering with react 18 #32188
Merged
gatsbybot
merged 14 commits into
gatsbyjs:master
from
wardpeet:feat/react-async-rendering
Jul 2, 2021
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
54bd8dc
feat(gatsby): enable replaceRenderer to be async
wardpeet 117c7aa
update tests
wardpeet 163f8fc
duplicated apiRunner for better results
wardpeet ff585df
enable async in everything
wardpeet 5784d7a
SAVEPOINT
wardpeet 605cfbc
fix error parsgin
wardpeet d6d5402
remove console.log
wardpeet aeb9cbe
fix tests
wardpeet 440f98e
add sync test
wardpeet 60d19cd
enable async rendering
wardpeet 4298bef
remove debug info
wardpeet 3770c1b
fix async
wardpeet cc09599
remove debug
wardpeet 9d2dcc2
Merge branch 'master' into feat/react-async-rendering
wardpeet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
packages/gatsby/cache-dir/server-utils/writable-as-promise.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import { Writable } from "stream" | ||
|
||
export class WritableAsPromise extends Writable { | ||
constructor() { | ||
super() | ||
|
||
this._output = `` | ||
this._deferred = { | ||
promise: null, | ||
resolve: null, | ||
reject: null, | ||
} | ||
this._deferred.promise = new Promise((resolve, reject) => { | ||
this._deferred.resolve = resolve | ||
this._deferred.reject = reject | ||
}) | ||
} | ||
|
||
_write(chunk, enc, cb) { | ||
this._output += chunk.toString() | ||
|
||
cb() | ||
} | ||
|
||
end() { | ||
this._deferred.resolve(this._output) | ||
|
||
this.destroy() | ||
} | ||
|
||
// disguise us as a promise | ||
then(resolve, reject) { | ||
return this._deferred.promise.then(resolve, reject) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to ignore errors here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we won't do streaming yet until libs have adopted and maybe we never do.
React still throws the error so this is just to don't show the warning.