-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conditional-page-builds): make it default #29548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small nits but nothing blocking
process.env.GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES && | ||
process.argv.includes(`--log-pages`) | ||
) { | ||
if (process.argv.includes(`--log-pages`)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we move this to the cli? 😬
Can you create a follow up ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we probably already get things on program
for it because we do let yargs
know about them (just hide them from --help
) -
gatsby/packages/gatsby-cli/src/create-cli.ts
Lines 246 to 261 in 1048eda
// log-pages and write-to-file were added specifically to experimental GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES feature | |
// in gatsby@2. They are useful, but not very applicable (specifically `--write-to-file`) as generic approach, as it only | |
// list pages without other artifacts, so it's useful in very narrow scope. Because we don't have alternative right now | |
// those toggles are kept for users that rely on them, but we won't promote them and will keep them "hidden". | |
.option(`log-pages`, { | |
type: `boolean`, | |
default: false, | |
describe: `Log the pages that changes since last build.`, | |
hidden: true, | |
}) | |
.option(`write-to-file`, { | |
type: `boolean`, | |
default: false, | |
describe: `Save the log of changed pages for future comparison.`, | |
hidden: true, | |
}), |
I'll create follow up ticket on that
Co-authored-by: Ward Peeters <[email protected]>
* feat(build): conditional page builds are no longer experimental (they are default) * Update docs/docs/conceptual/overview-of-the-gatsby-build-process.md Co-authored-by: Ward Peeters <[email protected]> * fix cli integration tests Co-authored-by: Ward Peeters <[email protected]>
Description
This removes
GATSBY_EXPERIMENTAL_PAGE_BUILD_ON_DATA_CHANGES
and makes the behaviour our default[ch25068]