Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix publishing scripts #28292

Merged
merged 2 commits into from
Nov 26, 2020
Merged

chore: fix publishing scripts #28292

merged 2 commits into from
Nov 26, 2020

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Nov 25, 2020

Description

This PR restores the old behavior for publish scripts when we called node scripts/clear-package-dir --verbose in the publish command directly vs. in the prepack lifecycle hook.

Somehow prepack hook is not called by lerna when publishing despite being listed here: https://github.com/lerna/lerna/tree/main/commands/publish#lifecycle-scripts

Or maybe it is called but doesn't work because it is interactive 🤷

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 25, 2020
@vladar vladar added topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 25, 2020
@vladar vladar requested a review from pieh November 25, 2020 20:23
@pieh
Copy link
Contributor

pieh commented Nov 25, 2020

I think something is weird here, because on master (so without changes in this PR) I did try "dry-run" (and disconnected internet for a duration of my "dry-run" test to not push things accidentally, and skipping checking if we are on the origin HEAD, because it just wouldn't work without internet of course) and using yarn run publish--next --no-push --no-git-tag-version I do get the prompt from scripts/clear-package-dir dir as expected:
Screenshot 2020-11-25 at 22 01 08

Not sure - it might be that those extra flags (--no-push / --no-git-tag-version) play a role here (I just wanted to use everything I can to prevent any pushing).

@pieh pieh merged commit aa9df5c into master Nov 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-publish-scripts branch November 26, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants