Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Convert flattened-plugins and resolved-nodes to TS #24062

Merged
merged 7 commits into from
May 28, 2020
Merged

chore(gatsby): Convert flattened-plugins and resolved-nodes to TS #24062

merged 7 commits into from
May 28, 2020

Conversation

alisson-suzigan
Copy link
Contributor

@alisson-suzigan alisson-suzigan commented May 13, 2020 •
edited
Loading

Description

This PR converts the following files to TS and updates its related files.

  • packages/gatsby/src/redux/reducers/flattened-plugins.js
  • packages/gatsby/src/redux/reducers/resolved-nodes.js

Related Issue

Related to #21995

@alisson-suzigan alisson-suzigan requested a review from a team as a code owner May 13, 2020 16:51
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 13, 2020
@blainekasten blainekasten mentioned this pull request May 13, 2020
Closed
@iamdarshshah iamdarshshah added type: TypeScript migration status: needs core review Currently awaiting review from Core team member labels May 13, 2020
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 14, 2020
@alisson-suzigan alisson-suzigan self-assigned this May 15, 2020
@alisson-suzigan alisson-suzigan changed the title chore(gatsby): Convert flattened-plugins reducer to TS chore(gatsby): Convert flattened-plugins and resolved-nodes to TS May 16, 2020
blainekasten
blainekasten approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: needs core review Currently awaiting review from Core team member labels May 28, 2020
@gatsbybot gatsbybot merged commit 4bb9228 into gatsbyjs:master May 28, 2020
johno pushed a commit to johno/gatsby that referenced this pull request May 28, 2020
@alisson-suzigan @blainekasten @johno
chore(gatsby): Convert flattened-plugins and resolved-nodes to TS (ga…
7ad7ac9 
…tsbyjs#24062)

* Convert flattened-plugins reducer to TS

* Update redux types by adding ISetResolvedNodesAction

* Convert resolved-nodes to TS

* Update redux index import

Co-authored-by: Blaine Kasten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees

@alisson-suzigan alisson-suzigan

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisson-suzigan @blainekasten @pieh @gatsbybot @iamdarshshah