chore(gatsby): disable loki stuff without dropping it #23646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdz
force-pushed
the
noloki
branch
2 times, most recently
from
09bb003 to
e1293bf
Compare
pvdz
force-pushed
the
noloki
branch
3 times, most recently
from
8f0e8b6 to
82a446e
Compare
sidharthachatterjee
previously approved these changes
May 1, 2020
|
Yeah we'll drop the whole thing at once next sprint. This is only commenting out the pieces that change things based on the flag. |
|
Added message to warn against usage. |
sidharthachatterjee
suggested changes
May 1, 2020
Co-authored-by: Sidhartha Chatterjee <[email protected]>
sidharthachatterjee
approved these changes
May 1, 2020
|
Published in [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents Loki from being used anymore within Gatsby.
The PR is only disabling Loki specific code paths, not removing them. That'll be a followup commit that's much more invasive than this one.
Basically, after this commit,
GATSBY_DB_NODES=lokishouldn't change anything anymore in terms of how Gatsby works.Also tried to disable circle ci checks for loki.