-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(babel-preset-gatsby): Convert path-serializer to TS #22035
Merged
pieh
merged 8 commits into
gatsbyjs:master
from
MichaelDeBoey:convert-babel-preset-gastby/path-serializer
Mar 9, 2020
Merged
chore(babel-preset-gatsby): Convert path-serializer to TS #22035
pieh
merged 8 commits into
gatsbyjs:master
from
MichaelDeBoey:convert-babel-preset-gastby/path-serializer
Mar 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbddd23
to
dfc14fa
Compare
dfc14fa
to
97070d6
Compare
blainekasten
previously approved these changes
Mar 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing, but once you get the tests to pass I am happy to merge this!
@blainekasten Can't figure out why the tests are failing tbh |
pieh
requested changes
Mar 9, 2020
Co-Authored-By: Michal Piechowiak <[email protected]>
pieh
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert
path-serializer
to TSRelated Issues
Related to #21995