Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated write-pages.md #19843

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Updated write-pages.md #19843

merged 3 commits into from
Dec 10, 2019

Conversation

KiranAkadas
Copy link
Contributor

Description

Updated Write-pages.md
Had to open a new pull request

Related Issues

Addresses #18284
Fixes #18914

@KiranAkadas KiranAkadas requested a review from a team as a code owner November 27, 2019 18:47
marcysutton
marcysutton suggested changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about subject -- this is also mentioned in the Gatsby Style Guide!

@KiranAkadas
Update docs/docs/write-pages.md
2e33fe1 
Co-Authored-By: Marcy Sutton <[email protected]>
@KiranAkadas
Copy link
Contributor Author

Sorry. I'd got that wrong

@LekoArts
Copy link
Contributor

LekoArts commented Dec 2, 2019

This is a duplicate to #18914

Please incorporate the changes you made here to your previous PR. Thanks!

@LekoArts LekoArts closed this Dec 2, 2019
@KiranAkadas
Copy link
Contributor Author

Hello.
I was actually having some problems with that repository and there were some changes that got pushed to the forked repo which were causing errors in my PRs and i had to delete that repository.
So, it would be great if you could consider this PR instead.

@LekoArts LekoArts mentioned this pull request Dec 2, 2019
Closed
@LekoArts LekoArts reopened this Dec 2, 2019
@laurieontech
Copy link
Contributor

Thanks for this! Going to merge now.

@laurieontech laurieontech merged commit 524bf4b into gatsbyjs:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcysutton marcysutton Awaiting requested review from marcysutton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KiranAkadas @LekoArts @laurieontech @marcysutton