fix(babel-preset-gatsby): Add babel-plugin-dynamic-import-node for tests #15657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
reviewed
Jul 12, 2019
wardpeet
reviewed
Jul 12, 2019
wardpeet
reviewed
Jul 12, 2019
sidharthachatterjee
force-pushed
the
fix/dynamic-import
branch
from
0c92ae9 to
5851a08
Compare
sidharthachatterjee
added a commit
that referenced
this pull request
Jul 12, 2019
sidharthachatterjee
added
the
bot: merge on green
sidharthachatterjee
added a commit
that referenced
this pull request
Jul 12, 2019
sidharthachatterjee
added a commit
that referenced
this pull request
Jul 12, 2019
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
…sts (gatsbyjs#15657) * Add babel-plugin-dynamic-import-node for tests * Add babel-plugin-dynamic-import-node to babel-preset-gatsby-package * Update snapshots * Consider BABEL_ENV as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 8 (which we still support) doesn't understand dynamic imports. While it's okay to keep these untranspiled (like in
gatsby-image/withIEPolyfill) because webpack will handle them anyway, this breaks tests run on Node 8 (https://circleci.com/gh/gatsbyjs/gatsby/169116?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link).To fix this, we need to conditionally transpile these to deferred requires for Node in test environments. This PR does that for this monorepo's jest config and for
babel-preset-gatsbywhich we recommend in https://www.gatsbyjs.org/docs/unit-testing/