fix(gatsby-plugin-sharp): Image rotation #14302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwgw
changed the title
wardpeet
reviewed
May 24, 2019
|
Fair enough. Thank you. I'm not sure why that gatsby-image test is failing. Is this fix breaking something else or is that unrelated? |
Co-Authored-By: Ward Peeters <[email protected]>
Co-Authored-By: Ward Peeters <[email protected]>
Co-Authored-By: Ward Peeters <[email protected]>
wardpeet
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rotating images with gatsby-plugin-sharp via the
rotateargument is currently broken.The plugin uses sharp's rotate method without args to lock-in orientation from EXIF. Unfortunately, this makes additional calls to rotate ineffectual.
This PR adds a check for the rotate arg and skips the early rotate call if the arg is provided and not equal to zero.
Related Issues
Fixes #5086