fix: don't use EnsureResources for development 404 page #10625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZYSzys
approved these changes
Dec 23, 2018
vtenfys
changed the title
pieh
approved these changes
Dec 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After PR #10224
EnsureResourcesthrows if there are no resources available for a route. It won't throw if there is custom 404 page (in that casehasResourceswill returntrueas it will load a 404 page resource).This PR checks if custom 404 page exists and if it doesn't
EnsureResourceswon't be used (there isn't anything to load). If we hit 404 page and custom 404 page exists we continue usingEnsureResourcesto make sure it loads properly.Related Issues
Fixes #10534
Fixes #10645