Skip to content

Commit

Permalink
New page extension ipynb needed added here
Browse files Browse the repository at this point in the history
  • Loading branch information
@KyleAMathews
KyleAMathews committed Sep 22, 2016
1 parent e7cec1e commit bc6d896
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/utils/page-file-types.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const pageFileTypes = [
'json',
'yaml',
'toml',
'ipynb',
]

export default pageFileTypes

4 comments on commit bc6d896

@rgbkrk
Copy link
Contributor

@rgbkrk rgbkrk commented on bc6d896 Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the one I missed.

Perhaps this list should be pulled from one spot?

@KyleAMathews
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be ideal.

The load-context.js file gets written to the project root (Webpack needs it there) so it could require the page-file-types module from the Gatsby install in node_modules.

Then we could further consolidate things by adding to page-file-types if a file is "static" (e.g. needs wrapped by a react component) or not (is a react component itself).

Want to take this on?

@rgbkrk
Copy link
Contributor

@rgbkrk rgbkrk commented on bc6d896 Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I just noticed I didn't force push a commit that added this on.

Then we could further consolidate things by adding to page-file-types if a file is "static" (e.g. needs wrapped by a react component) or not (is a react component itself).

That makes sense.

Want to take this on?

Let me get the flow working with a notebook here and start using gatsby a bit more. If you still have that as an open issue then I can tackle it.

@KyleAMathews
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! I'll open an issue and assign it to you :-) It's not a pressing problem but it'd be nice to fix.

Please sign in to comment.