fix(gatsby-transformer-remark): render html attributes in html excerpt (

#10196) * track markdown properties * fix image markdown
gatsbyjs · Nov 30, 2018 · 2483aef · 2483aef
1 parent 71d7f23
commit 2483aef
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/gatsby-transformer-remark/src/__tests__/__snapshots__/extend-node.js.snap b/packages/gatsby-transformer-remark/src/__tests__/__snapshots__/extend-node.js.snap
@@ -57,7 +57,7 @@ Object {
 
 exports[`Excerpt is generated correctly from schema given an html format, it correctly maps nested markdown to html 1`] = `
 Object {
-  "excerpt": "<p>Where oh <a><em>where</em></a> <strong><em>is</em></strong> that pony?</p>",
+  "excerpt": "<p>Where oh <a href=\\"nick.com\\"><em>where</em></a> <strong><em>is</em></strong> <img src=\\"pony.png\\" alt=\\"that pony\\">?</p>",
   "frontmatter": Object {
     "title": "my little pony",
   },

diff --git a/packages/gatsby-transformer-remark/src/__tests__/extend-node.js b/packages/gatsby-transformer-remark/src/__tests__/extend-node.js
@@ -245,7 +245,7 @@ title: "my little pony"
 date: "2017-09-18T23:19:51.246Z"
 ---
 
-Where oh [*where*](nick.com) **_is_** that pony?`,
+Where oh [*where*](nick.com) **_is_** ![that pony](pony.png)?`,
     `excerpt(format: HTML)
     frontmatter {
         title
@@ -254,7 +254,7 @@ Where oh [*where*](nick.com) **_is_** that pony?`,
     node => {
       expect(node).toMatchSnapshot()
       expect(node.excerpt).toMatch(
-        `<p>Where oh <a><em>where</em></a> <strong><em>is</em></strong> that pony?</p>`
+        `<p>Where oh <a href="nick.com"><em>where</em></a> <strong><em>is</em></strong> <img src="pony.png" alt="that pony">?</p>`
       )
     }
   )

diff --git a/packages/gatsby-transformer-remark/src/hast-processing.js b/packages/gatsby-transformer-remark/src/hast-processing.js
@@ -4,6 +4,7 @@ function duplicateNode(node) {
     children: [],
     tagName: node.tagName,
     value: node.value,
+    properties: node.properties,
   }
 }