Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ConsoleOut in Windows logger #480

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Mar 5, 2024

Ticket(s)

Description

The Windows logger uses a different file that omits syslog, hence is usually overlooked. This fixes the ConsoleOut feature implemented by @Hamsajj in #457.

Related PRs

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa mostafa merged commit f7608c2 into main Mar 5, 2024
4 checks passed
@mostafa mostafa deleted the fix-logger-for-windows branch March 5, 2024 17:22
smnmna99 pushed a commit that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant