Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withdraw l2 #36

Merged
merged 6 commits into from
Feb 29, 2024
Merged

withdraw l2 #36

merged 6 commits into from
Feb 29, 2024

Conversation

stanieltron
Copy link
Member

No description provided.

@github-actions github-actions bot temporarily deployed to pr-36 February 22, 2024 12:39 Destroyed
Copy link
Member

@mateuszaaa mateuszaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process cancel is super unreadable, could you refactor it please to sth like

for (request of requests){
 (request_id, request_type) = getNextRequest()
 if (request_type == deposit){
     proces_deposit(request_id);
     
 }
 // ..etc
}

also from what i understand now requests results are processed first while i think they should be processed in order taking into account cancels, and withdrawals??

im i missing something

@github-actions github-actions bot temporarily deployed to pr-36 February 23, 2024 08:09 Destroyed
@github-actions github-actions bot temporarily deployed to pr-36 February 28, 2024 14:32 Destroyed
@github-actions github-actions bot temporarily deployed to pr-36 February 29, 2024 11:15 Destroyed
@mateuszaaa mateuszaaa merged commit 2921311 into main Feb 29, 2024
12 checks passed
@mateuszaaa mateuszaaa deleted the feature/l2-side-withdraw branch February 29, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants