Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Commit

Permalink
Remove all references to --external-assets
Browse files Browse the repository at this point in the history
  • Loading branch information
garronej committed Mar 28, 2021
1 parent 21d4f88 commit 95fc9da
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ jobs:
with:
name: build
path: build
- run: npx -y -p keycloakify@$VER build-keycloak-theme --external-assets
- run: npx -y -p keycloakify@$VER build-keycloak-theme
env:
VER: ${{ needs.test.outputs.keycloakify_version }}
- name: Upload keycloak theme
Expand Down
9 changes: 2 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@ To enables the CI to publish on DockerHub on your behalf go to
repository ``Settings`` tab, then ``Secrets`` you will need to add two new secrets:
- ``DOCKERHUB_TOKEN``, you Dockerhub authorization token.
- ``DOCKERHUB_USERNAME``, Your Dockerhub username.

# About keycloakify

This repo is currently configured to build the theme with [`--external-assets`](https://github.com/InseeFrLab/keycloakify#specify-from-where-the-resources-should-be-downloaded).
If you want the theme to be standalone just remove `--external-assets` [here](https://github.com/garronej/keycloakify-demo-app/blob/f87f211c433d1520c9ecf66565c6b88779aa98ed/.github/workflows/ci.yaml#L139).
# Notes for self
# Docker

```bash
docker build -f Dockerfile -t garronej/keycloakify-demo-app:test .
Expand All @@ -40,6 +35,6 @@ yarn && yarn build && tar -cvf build.tar ./build && docker build -f Dockerfile.c

docker run -it -dp 8083:80 garronej/keycloakify-demo-app:test

# http://localhost:8083/keycloakify-demo-app won't work because of the nginx.config for / and not /keycloakify-demo-app
```

http://localhost:8083/keycloakify-demo-app
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"homepage": "https://garronej.github.io/keycloakify-demo-app/",
"name": "keycloakify-demo-app",
"version": "0.2.9",
"version": "0.2.10",
"description": "A demo project for keycloakify",
"repository": {
"type": "git",
Expand All @@ -22,7 +22,7 @@
"react-dom": "^17.0.1",
"tss-react": "^0.0.11",
"web-vitals": "^1.0.1",
"keycloakify": "^0.3.13"
"keycloakify": "^0.3.15"
},
"devDependencies": {
"@testing-library/jest-dom": "^5.11.4",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7199,10 +7199,10 @@ jsprim@^1.2.2:
array-includes "^3.1.2"
object.assign "^4.1.2"

keycloakify@^0.3.13:
version "0.3.13"
resolved "https://registry.yarnpkg.com/keycloakify/-/keycloakify-0.3.13.tgz#9bdf8bcc482a8b192fd8022116599d372c31a889"
integrity sha512-gM8PZDzmWlVjfwoa2dYkzqs9AUHXN+aBIhKb4wDyzzy9XoxIL1TQr9VXhH1TFkFnqxyazn0mMQK+cICUYIiXTA==
keycloakify@^0.3.15:
version "0.3.15"
resolved "https://registry.yarnpkg.com/keycloakify/-/keycloakify-0.3.15.tgz#730b2d5388bb3836e6f819542e6d778b487b15e1"
integrity sha512-vB0Lai9DHw2HJCKiBtXg+OHnj2z5Yq6/+d+Tha2ZyJ+ZZoV1HxwaMBYPK004AhNT46TsDXCoQbuwPoQTr1Wf5g==
dependencies:
cheerio "^1.0.0-rc.5"
evt "2.0.0-beta.15"
Expand Down

0 comments on commit 95fc9da

Please sign in to comment.