-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/gardener/gardener from 1.110.3 to 1.111.1 #175
Bump github.com/gardener/gardener from 1.110.3 to 1.111.1 #175
Conversation
Bumps [github.com/gardener/gardener](https://github.com/gardener/gardener) from 1.110.3 to 1.111.1. - [Release notes](https://github.com/gardener/gardener/releases) - [Commits](gardener/gardener@v1.110.3...v1.111.1) --- updated-dependencies: - dependency-name: github.com/gardener/gardener dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
@dependabot[bot] Thank you for your contribution. |
Thank you @dependabot[bot] for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
g.Expect(string(response)).To(g.Equal(fmt.Sprintf("%s\n", "1"))) | ||
g.Expect(string(errorResponse)).To(g.Equal(fmt.Sprintf("%s\n", "1"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the right variable that holds the exit code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you are right, this test was bad. We are running a Pod that greps and counts how many times "gVisor" was found in dmesgs output. If grep would return something on stderr, it would probably return with an err
anyway and we check for that. Hence, removing any glance at stderr and restoring this tests to what it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, now we check twice for: g.Expect(err).ToNot(g.HaveOccurred())
Otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, now we check twice for:
g.Expect(err).ToNot(g.HaveOccurred())
Otherwise looks good.
Argh... 🤦 Fixed, PTAL.
A newer version of github.com/gardener/gardener exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@Roncossek Fixed your suggestions, PTAL |
Bumps github.com/gardener/gardener from 1.110.3 to 1.111.1.
Release notes
Sourced from github.com/gardener/gardener's releases.
... (truncated)
Commits
14dbecb
Release v1.111.1323e637
chore(deps): update dependency gardener/dashboard to v1.79.1 (#11262)e2af210
[release-v1.111] Create a wrapper forOperatingSystemConfig
provisioning ba...995b550
RootPodExecutor: Do not require output from command execution (#11253)0fd12b3
Fix nil pointer deref in Structured Authn (#11233)0ca15eb
Prepare next Development Cycle v1.111.1-dev37ae9bf
Release v1.111.08fda81b
chore(deps): update registry.k8s.io/ingress-nginx/controller-chroot docker ta...fa1658e
Consider machine image name while calculating list of valid image (#11220)822c574
Fix TM testShoot container runtime testing
(#11219)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)