Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exhaustion of request quotas on concurrent certificates with same domain name #399

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Fix exhaustion of request quotas on concurrent certificates with same domain name #399

merged 2 commits into from
Feb 3, 2025

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Jan 30, 2025 •
edited
Loading

How to categorize this PR?

/kind bug

What this PR does / why we need it:
If two certificates with the same set of domain names are created at the same time, they are reconciled often and use up the certificate request quota ("request quota per day").
This is a fix to count the reconciliation only if all preconditions for the request are fulfilled.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix exhaustion of request quotas on concurrent certificates with same domain name

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Jan 30, 2025

@MartinWeindel: The label(s) kind/todo cannot be applied, because the repository doesn't have them.

In response to this:

How to categorize this PR?

/kind TODO

What this PR does / why we need it:
If two certificates with the same set of domain names are created at the same time, they are reconciled often and use up the certificate request quota ("request quota per day").
This is a fix to count the reconciliation only if all preconditions for the request are fulfilled.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix exhaustion of request quotas on concurrent certificates with same domain name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot requested a review from marc1404 January 30, 2025 17:44
@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 30, 2025
@MartinWeindel
Copy link
Member Author

/kind bug

@gardener-prow gardener-prow bot added kind/bug Bug and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 30, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 30, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 31, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 31, 2025
marc1404
marc1404 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Feb 3, 2025

LGTM label has been added.

Git tree hash: 0d29a2964ce1abcc147470b2cc5f0a093bbeb6df

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marc1404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@gardener-prow gardener-prow bot merged commit 331034e into master Feb 3, 2025
14 checks passed
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 3, 2025
@marc1404 marc1404 deleted the fix/exhausted-quotas branch February 6, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 approved these changes

Assignees

@marc1404 marc1404

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @marc1404 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3