Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update module github.com/letsencrypt/pebble/v2 to v2.7.0 #394

Merged
merged 3 commits into from
Jan 24, 2025
Merged

fix(deps): update module github.com/letsencrypt/pebble/v2 to v2.7.0 #394

merged 3 commits into from
Jan 24, 2025

Conversation

gardener-ci-robot
Copy link
Collaborator

This PR contains the following updates:

Package Type Update Change
github.com/letsencrypt/pebble/v2 require minor v2.6.0 -> v2.7.0

Release Notes

letsencrypt/pebble (github.com/letsencrypt/pebble/v2)

v2.7.0

Compare Source

What's Changed

Full Changelog: letsencrypt/pebble@v2.6.0...v2.7.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@gardener-ci-robot gardener-ci-robot added the kind/enhancement Enhancement, improvement, extension label Jan 24, 2025
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2025
@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2025
marc1404
marc1404 reviewed Jan 24, 2025
View reviewed changes
test/utils/pebble.go
Comment on lines +40 to +49
profiles = map[string]ca.Profile{
"default": {
Description: "The profile you know and love",
ValidityPeriod: 7776000,
},
"shortlived": {
Description: "A short-lived cert profile, without actual enforcement",
ValidityPeriod: 518400,
},
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for ACME profiles was added with Pebble v2.7.0:
https://github.com/letsencrypt/pebble/releases/tag/v2.7.0#:~:text=Add%20support%20for%20ACME%20Profiles

marc1404
marc1404 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marc1404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Jan 24, 2025

LGTM label has been added.

Git tree hash: 283125b6607bf4cd5e02327dbc94afaa1fddba03

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 24, 2025
@gardener-ci-robot
Copy link
Collaborator Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@gardener-prow gardener-prow bot merged commit e7f4cbd into master Jan 24, 2025
14 checks passed
@marc1404 marc1404 deleted the renovate/github.jparrowsec.cn-letsencrypt-pebble-v2-2.x branch January 24, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 approved these changes

@MartinWeindel MartinWeindel Awaiting requested review from MartinWeindel

Assignees

@marc1404 marc1404

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gardener-ci-robot @marc1404 @gardener-robot-ci-1 @gardener-robot-ci-3