This repository has been archived by the owner on Sep 11, 2022. It is now read-only.
Some minor linting fixes and cleanup #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My team is using this plugin and I noticed a few places that needed to be cleaned up and optimized: 1. A bunch of inconsistency with the use of strict equality (`===`). Strict equality should always be used when you're not dealing with falsey objects (i.e. `null == undefined` is permitted, so therefore `obj == null` or `obj == undefined` is permissible) 2. There was a missing semicolon. Every other line ends with a semicolon, so that one needed one as well. 3. A minor for loop optimization would be to cache the length of the for loop inside of a variable in the first portion of the loop. This saves having to call length every single time.While this is optimized in modern browsers, given you support legacy browsers, this is a worthwhile optimization.
garand
added a commit
that referenced
this pull request
Aug 18, 2015
Some minor linting fixes and cleanup
|
Thanks for contributing! Glad you're enjoying the plugin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team is using this plugin and I noticed a few places that needed to be cleaned up and optimized:
===). Strict equality should always be used when you're not dealing with falsey objects (i.e.null == undefinedis permitted, so thereforeobj == nullorobj == undefinedis permissible)