-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/Add toggle focus mode #64
Conversation
✅ Deploy Preview for eletypes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… timer will show modal in status === "finished" and user already played 5 minutes
move expensive tasks to web worker to prevent UI lag
Let us make this feature a button at the below next to the "word" , it will be only showing up when users at words mode, it also use the local storage to store the user preference. It will not show in the other mode. |
ouhh okey sir, i would make it today |
new-feature.mp4done |
})} | ||
</div> | ||
<> | ||
<SocialLinksModal status={status} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it shows up in the middle of the screen with a backdrop. can we make this less aggressive if it is going to be blocking the user view suddenly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to ship the ultra zoom mode first, can temporarily remove this sociallinkmodal for now, we would probably ship this later in a separate pull request.
I think the logic is to 5 minutes users are seeing this modal shows up. And it is blocking users to see the status.
So in that case, let's not make it to a module, but a regular div shows up everytime the game is finished.
< Visualization chart component>
< Stats component>
< Share(an icon group)>
when you click any of the social media button, then a modal pops up, to confirm the share. The V0 content would be simply "I have completed a typing challenge with XXX WPM", V1 would be a formatted svg / html/ image that we could create a certificate.
So I think there is something we need to plan first before shipping in this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i made it hidden
Co-authored-by: MUYANGGUO <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, feel free to merge, and you can add the feature description in the readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me block the merging first
great |
cool-feature.mp4