Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Add toggle focus mode #64

Merged
merged 29 commits into from
Aug 23, 2024
Merged

Conversation

rendivs925
Copy link
Contributor

cool-feature.mp4

@rendivs925 rendivs925 changed the title Add toggle focus mode feat/Add toggle focus mode Aug 16, 2024
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for eletypes ready!

Name Link
🔨 Latest commit 2563efd
🔍 Latest deploy log https://app.netlify.com/sites/eletypes/deploys/66c83494e9694a0008c4c2ca
😎 Deploy Preview https://deploy-preview-64--eletypes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MUYANGGUO
Copy link
Member

Let us make this feature a button at the below next to the "word" , it will be only showing up when users at words mode, it also use the local storage to store the user preference. It will not show in the other mode.

@rendivs925
Copy link
Contributor Author

Let us make this feature a button at the below next to the "word" , it will be only showing up when users at words mode, it also use the local storage to store the user preference. It will not show in the other mode.

ouhh okey sir, i would make it today

@rendivs925
Copy link
Contributor Author

new-feature.mp4

done

})}
</div>
<>
<SocialLinksModal status={status} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it shows up in the middle of the screen with a backdrop. can we make this less aggressive if it is going to be blocking the user view suddenly.

Copy link
Member

@MUYANGGUO MUYANGGUO Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to ship the ultra zoom mode first, can temporarily remove this sociallinkmodal for now, we would probably ship this later in a separate pull request.
I think the logic is to 5 minutes users are seeing this modal shows up. And it is blocking users to see the status.
So in that case, let's not make it to a module, but a regular div shows up everytime the game is finished.

< Visualization chart component>

< Stats component>

< Share(an icon group)>
when you click any of the social media button, then a modal pops up, to confirm the share. The V0 content would be simply "I have completed a typing challenge with XXX WPM", V1 would be a formatted svg / html/ image that we could create a certificate.
So I think there is something we need to plan first before shipping in this pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i made it hidden

Copy link
Member

@MUYANGGUO MUYANGGUO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, feel free to merge, and you can add the feature description in the readme.

Copy link
Member

@MUYANGGUO MUYANGGUO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me block the merging first

@MUYANGGUO MUYANGGUO merged commit 7e6f2c4 into gamer-ai:main Aug 23, 2024
4 checks passed
@rendivs925
Copy link
Contributor Author

great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants