Clean the buffering strategies code and provide example models #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngController instead - also normalizes method names and remove a few warnings - removes unused save method in csvsaver
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -104,41 +104,6 @@ public class GAMA { | |||
| // hqnghi: add several controllers to have multi-thread experiments | |||
| private static final List<IExperimentController> controllers = new CopyOnWriteArrayList<>(); | |||
|
|
|||
| private static final BufferingController bufferingController = new BufferingController(); | |||
There was a problem hiding this comment.
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 30.51% to 39.13%, threshold = 30.0%
| @@ -124,7 +123,7 @@ public void save(final IScope scope, final IExpression item, final File file, fi | |||
| sb.append(Strings.LN); | |||
| } | |||
| if (itemType.id() == IType.MATRIX) { | |||
| GamaMatrix<?> matrix = (GamaMatrix) value; | |||
| GamaMatrix<?> matrix = (GamaMatrix<?>) value; | |||
There was a problem hiding this comment.
ℹ Getting worse: Complex Method
save increases in cyclomatic complexity from 20 to 21, threshold = 9
Comment on lines
-156
to
-159
| private void save(final IScope scope, final File file, final boolean header, final IExpression item, final BufferingStrategies bufferingStrategy) | ||
| throws GamaRuntimeException { | ||
|
|
||
| } |
There was a problem hiding this comment.
✅ No longer an issue: Excess Number of Function Arguments
save is no longer above the threshold for number of arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.