A better handling of old workspaces (fixes #224) #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a workspace created with a previous version of GAMA is opened, the dialog now asks if the user wants to update it -- and we clear the old state if yes (prefs of plugins, etc.).
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+244
to
+246
| && openQuestion(null, "Different version of the models library", | ||
| "The workspace contains a different version of the models library. Do you want GAMA to proceed and update it ?"); | ||
| if (remember) { clearWorkspace(true); } |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
checkWorkspace increases in cyclomatic complexity from 16 to 17, threshold = 9
| @@ -241,8 +241,9 @@ public static Object checkWorkspace() throws IOException { | |||
| // this stage | |||
| if (ret != null) { | |||
| remember = "models".equals(ret) && WorkspacePreferences.askBeforeUsingOutdatedWorkspace() | |||
| && !openQuestion(null, "Different version of the models library", | |||
| "The workspace contains a different version of the models library. Do you want to use another workspace ?"); | |||
| && openQuestion(null, "Different version of the models library", | |||
There was a problem hiding this comment.
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.20 to 4.30, threshold = 4
Comment on lines
+244
to
+246
| && openQuestion(null, "Different version of the models library", | ||
| "The workspace contains a different version of the models library. Do you want GAMA to proceed and update it ?"); | ||
| if (remember) { clearWorkspace(true); } |
There was a problem hiding this comment.
❌ New issue: Deep, Nested Complexity
checkWorkspace has a nested complexity depth of 4, threshold = 4
| @@ -246,11 +246,12 @@ public static String checkWorkspaceDirectory(final String workspaceLocation, fin | |||
| if (askBeforeUsingOutdatedWorkspace()) { | |||
| create = MessageDialog.openQuestion(Display.getDefault().getActiveShell(), | |||
| "Different version of the models library", | |||
| "The workspace contains a different version of the models library. Do you want to proceed anyway ?"); | |||
| "The workspace contains a different version of the models library. Do you want GAMA to proceed and update it ?"); | |||
There was a problem hiding this comment.
ℹ Getting worse: Complex Method
checkWorkspaceDirectory already has high cyclomatic complexity, and now it increases in Lines of Code from 71 to 72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a workspace created with a previous version of GAMA is opened, the dialog now asks if the user wants to update it -- and we clear the old state if yes (prefs of plugins, etc.). It should cover 90% of the usages.