-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of concatenate operator #292
Conversation
Takes a list of strings in parameter and produces the string resulting from their concatenation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.00 (7.11 -> 7.11)
- Improving Code Health: 2 findings(s) ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.00 (7.11 -> 7.11)
- Improving Code Health: 2 findings(s) ✅
@@ -10,19 +10,20 @@ | |||
package gama.gaml.operators; | |||
|
|||
import java.nio.charset.StandardCharsets; | |||
import java.util.StringJoiner; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 85.19% to 79.66%, threshold = 30.0%
@@ -10,19 +10,20 @@ | |||
package gama.gaml.operators; | |||
|
|||
import java.nio.charset.StandardCharsets; | |||
import java.util.StringJoiner; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Getting better: String Heavy Function Arguments
The ratio of strings in function arguments decreases from 72.22% to 67.80%, threshold = 39.0%
It is indeed way more efficient to save big files as demonstrated by this example model:
|
Takes a list of strings in parameter and produces the string resulting from their concatenation