Code cleanup #133
Merged
Code cleanup #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Force typing instead of Object everywhere - test for NPE in some forgotten cases - Fix cast to NormStatement instead of Norm which resulted in runtime errors in probabilistic mode
Removes useless casts
- change division types inside Math.round to double so it's floating point division and not int - convert Math.round results from long to int to fit the rest of the program - removes useless Math.round (Once used as a cast to an int and the others probably as legacy)
- uses the equals method to compare objects of class Double instead of == - changes hard to read streams to get min and max by Collections.min and Collections.max
It was not set anywhere
- avoid NPE in some cases - move the code outside of any condition so the vertexSpecies is set no matter what
Because we already have the clone method so there's no reason not using the known interface
same reason as for GamaPoint
- use standard java casing - some light comments improvements - use of a record instead of a class for DisplayParametersStructure - adding some final modifiers when it makes sense
- revert the record to use a static class instead - renaming to follow java conventions - "optimize" float parsing - simplifies some code
- use StringBuilder in loops - replace new String() by constant ""
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
gama.core/src/gama/core/kernel/batch/exploration/sobol/SobolExploration.java
Show resolved
Hide resolved
- prevents a potential NPE + fixes a logical bug in bdi - iterates over sets with entrySet instead of keySet when values are needed - removes an unused variable in imagelayer - switches a boxed variable to int in masked_by operator - removes the fake bug for spotbugs to pickup on in LoopStatement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently cleaning the code base helped by spotbugs and other code-analysis tools.
Feel free to participate if you want.
Also the scope of this rework is super wide so do not hesitate to review the parts of the code you have some knowledge over as I may (and surely will) introduce new bugs.