-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature space visualization tool + side by side gifs visual #29
Merged
gallettilance
merged 9 commits into
gallettilance:main
from
SunehB:feature_space_visual
Nov 30, 2024
Merged
Feature space visualization tool + side by side gifs visual #29
gallettilance
merged 9 commits into
gallettilance:main
from
SunehB:feature_space_visual
Nov 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gallettilance
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please:
- adjust the test
- add to the readme
- fix linting issues
- address comments
I know that's a lot - no rush! :)
83dcc71
to
f4d5798
Compare
gallettilance
requested changes
Nov 29, 2024
gallettilance
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Added functions fit_in_feature_space and _snap_feature_space in visualizer.py to visualize the learned decision boundary in the feature space
Added function combine_gifs to visualize the learned decision boundary gifs side by side
Added test_feature_space in test_visualizer.py
Motivation for the change:
We wanted a way to visualize gifs side by side
Visualizing the decision boundary in the feature space can show how the network transforms data to make it linearly separable
Reviewer Checklist