Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature space visualization tool + side by side gifs visual #29

Merged
merged 9 commits into from
Nov 30, 2024

Conversation

SunehB
Copy link
Contributor

@SunehB SunehB commented Nov 16, 2024

Description of the change:
Added functions fit_in_feature_space and _snap_feature_space in visualizer.py to visualize the learned decision boundary in the feature space
Added function combine_gifs to visualize the learned decision boundary gifs side by side
Added test_feature_space in test_visualizer.py

Motivation for the change:
We wanted a way to visualize gifs side by side
Visualizing the decision boundary in the feature space can show how the network transforms data to make it linearly separable

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient test coverage
  • Docs updated
  • Commit messages sensible and descriptive

Copy link
Owner

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  1. adjust the test
  2. add to the readme
  3. fix linting issues
  4. address comments

I know that's a lot - no rush! :)

@SunehB SunehB force-pushed the feature_space_visual branch from 83dcc71 to f4d5798 Compare November 29, 2024 20:12
@gallettilance gallettilance merged commit fb9313e into gallettilance:main Nov 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants