Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump requirements for galaxy packages to 24.2 #1491

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Feb 12, 2025

No description provided.

@bernt-matthias
Copy link
Contributor

Seems that only the new linter errors like:

WARNING (TestsCaseValidation): Test 1: failed to validate test parameters against inputs - tests won't run on a modern Galaxy tool profile version. Validation errors are [1 validation error for PydanticModelFor[empty_cdata]

are due to 24.2. Wondering if we should update the test tools / change the test (e.g. by adding a skip rule for the TestsCaseValidation linter). What do you think @jmchilton ?

@bernt-matthias
Copy link
Contributor

bernt-matthias commented Feb 14, 2025

The autoupdate test apparently fails due to (but this is unrelated to this PR IMO):

  File "/home/berntm/tmp/.venv-planemo/lib/python3.12/site-packages/planemo/autoupdate.py", line 287, in _update_wf
    config.user_gi.workflows.refactor_workflow(wf["id"], actions=[{"action_type": "upgrade_all_steps"}])
  File "/home/berntm/tmp/.venv-planemo/lib/python3.12/site-packages/bioblend/galaxy/workflows/__init__.py", line 713, in refactor_workflow
    return self._put(payload=payload, url=url)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/berntm/tmp/.venv-planemo/lib/python3.12/site-packages/bioblend/galaxy/client.py", line 190, in _put
    return self.gi.make_put_request(url, payload=payload, params=params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/berntm/tmp/.venv-planemo/lib/python3.12/site-packages/bioblend/galaxyclient.py", line 265, in make_put_request
    raise ConnectionError(
bioblend.ConnectionError: Unexpected HTTP status code: 400: {"err_msg":"Workflow step has upgrade messages","err_code":0,"err_data":{"1":{"report_format|report_format_select":"No value found for 'Choose a report format'. Using default: 'txt_lines'.","report_format|unified":"No value found for 'Output this amount of lines of unified context'. Using default: '3'."}}}

@mvdbeek do you have any idea what could be a reason?

@bernt-matthias
Copy link
Contributor

In the browser I get

Screenshot from 2025-02-15 10-05-00

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there are only 3 test failing which also failed before (all workflows tests .. I will try to mention this in the next workflow group meeting).

test_ok_http just fails because it refers to a tool on the master branch (via http) that will just be fixed in this PR. This is covered by other tests as far as I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants