Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntentionId should be added to event's data #248

Closed
mckrava opened this issue May 7, 2021 · 0 comments · Fixed by #262
Closed

IntentionId should be added to event's data #248

mckrava opened this issue May 7, 2021 · 0 comments · Fixed by #262
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mckrava
Copy link
Contributor

mckrava commented May 7, 2021

https://github.com/galacticcouncil/HydraDX-node/blob/6692079e84784eab8915be1fe5f42847b4f8a7fd/pallets/exchange/src/lib.rs#L151
@jak-pan jak-pan added good first issue Good for newcomers help wanted Extra attention is needed labels May 12, 2021
unordered-set added a commit to unordered-set/HydraDX-node that referenced this issue May 25, 2021
@unordered-set
feat(exchange): Update IntentionResolvedDirectTradeFees event
d0def8b 
Add intention_id to the IntentionResolvedDirectTradeFees event.
This commit resolves galacticcouncil#248.
@unordered-set unordered-set mentioned this issue May 25, 2021
Merged
1 task
unordered-set added a commit to unordered-set/HydraDX-node that referenced this issue May 25, 2021
@unordered-set
feat(exchange): Update IntentionResolvedDirectTradeFees event
5fa006b 
Add intention_id to the IntentionResolvedDirectTradeFees event.
This commit resolves galacticcouncil#248.
unordered-set added a commit to unordered-set/HydraDX-node that referenced this issue May 25, 2021
@unordered-set
feat(exchange): Update IntentionResolvedDirectTradeFees event
0482012 
Add intention_id to the IntentionResolvedDirectTradeFees event.
This commit resolves galacticcouncil#248.
unordered-set added a commit to unordered-set/HydraDX-node that referenced this issue May 25, 2021
@unordered-set
feat(exchange): Update IntentionResolvedDirectTradeFees event
c71e596 
Add intention_id to the IntentionResolvedDirectTradeFees event.
This commit resolves galacticcouncil#248.
unordered-set added a commit to unordered-set/HydraDX-node that referenced this issue May 26, 2021
@unordered-set
feat(exchange): Update IntentionResolvedDirectTradeFees event
35d8ba4 
Add intention_id to the IntentionResolvedDirectTradeFees event.
This commit resolves galacticcouncil#248.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(exchange)!: Update IntentionResolvedDirectTradeFees event unordered-set/HydraDX-node
2 participants
@jak-pan @mckrava