feat(exchange)!: Update IntentionResolvedDirectTradeFees event #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unordered-set
force-pushed
the
feat/add-intention-id-to-fee-event
branch
3 times, most recently
from
0482012 to
c71e596
Compare
enthusiastmartin
approved these changes
May 26, 2021
Add intention_id to the IntentionResolvedDirectTradeFees event. This commit resolves galacticcouncil#248.
unordered-set
force-pushed
the
feat/add-intention-id-to-fee-event
branch
from
c71e596 to
35d8ba4
Compare
jak-pan
reviewed
May 27, 2021
| @@ -260,9 +261,10 @@ impl<'a, T: Config> DirectTradeData<'a, T> { | |||
| } | |||
|
|
|||
| /// Send pallet event after a fee is transferred. | |||
| fn send_trade_fee_event(from: &T::AccountId, to: &T::AccountId, asset: AssetId, amount: Balance) { | |||
| fn send_trade_fee_event(from: &T::AccountId, intention: &Intention<T>, to: &T::AccountId, asset: AssetId, amount: Balance) { | |||
There was a problem hiding this comment.
Do we only send fee from one side?
There was a problem hiding this comment.
it is sent for each intention/transaction. you can see it in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add intention_id to the IntentionResolvedDirectTradeFees event.
This commit resolves #248.
This change changes the signature of the IntentionResolvedDirectTradeFees event.
I think it does it for good - to be similar to
IntentionResolvedDirectTradeDescription
The change is pretty straightforward, on each direct match we have access to two intentions and by the
fee: trueflag we already know all of the tranansactions which are taking part in taking the fees. Also those transactions has a fieldfrom. So, by matching thatfromfield with intention data we are computing the intention IDs.In my opinion it is a pretty robust way of doing things. Because I didn't touch the matching rules, and also, the change will adopt itself to any further changes in the fees rules.
Related Issue
Fixes: #248
Motivation and Context
That missing field is pretty important to any tools which want to drill down into the transaction costs. Otherwise they all will have the same snippet of decyphering other emitted events.
How Has This Been Tested?
Run tests locally. Worked. Unbelivable. Broke tests, verified they got broken. Fixed back.
Checklist: