This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
sign_transaction_sync #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* Expanded match interface into options for filtering by test name, contract name, and their inverse * Added forge::TestFilter impl for Filter && replaced Regex with Filter * Added TestFilter trait * Replaced Regex with TestFilter * Replaced Regex with TestFilter * Cleaned up warnings * Formatting * Add conflicts for old match flag and new expaded match flags * Added TestFilter impl to test_helpers * Replaced Regex in tests with impl TestFilter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Walletstruct implements theSignertrait to expose thesign_transaction()function which doesn't do any async calls, but it's still exposed through the async interface. This makes it complex to use in environments where there's no async runtime.Solution
Created a new public, sync function and moved the code from the async funtion to this one. Wasn't sure what name to use on the new function, but open to suggestions