This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(abigen): contract names can be reserve words #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re #989 |
mattsse
reviewed
Jul 21, 2022
clifton
force-pushed
the
fix-abigen-reserve-words
branch
from
12e1cc9 to
4b87c03
Compare
|
ok @mattsse i made that change and fixed it up. should be good to go. |
gakonst
approved these changes
Jul 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some contract names (such as Enum.sol in gnosis) are rust reserve words that cause invalid bindings to be generated.
PR Checklist