Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak in ws client #228

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

SC4RECOIN
Copy link
Contributor

@SC4RECOIN SC4RECOIN commented Jul 3, 2024

if the write fails then an error is returned but the sub still exists in the map with no way to clear it

sub objects are pretty large which leads to a significant memory leak on repeated calls with write failures

@gagliardetto gagliardetto merged commit 05e94f2 into gagliardetto:main Oct 10, 2024
@gagliardetto
Copy link
Owner

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants