Reduce test flakiness by awaiting all test navigations

gadget-inc · Nov 2, 2023 · 7e05cc5 · 7e05cc5
1 parent 2d6cb1c
commit 7e05cc5
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/packages/test-apps/simple-react/test/navigation-details.spec.ts b/packages/test-apps/simple-react/test/navigation-details.spec.ts
@@ -14,6 +14,9 @@ describe('navigation details', () => {
     await page.click('#home-link')
 
     const testCalls: any[] = await page.evaluate('window.test')
+
+    await page.waitForFunction(() => window.test.length === 2)
+
     expect(testCalls).toBeDefined()
     expect(testCalls).toHaveLength(2)
     expect(testCalls[0].isNavigating).toBe(false)
@@ -31,6 +34,8 @@ describe('navigation details', () => {
 
     await page.click('#section-link')
 
+    await page.waitForFunction(() => window.test.length === 3)
+
     const testCalls: any[] = await page.evaluate('window.test')
     expect(testCalls).toBeDefined()
     expect(testCalls[0].isNavigating).toBe(false)