Added Catch v3 support #2661
Merged
Added Catch v3 support #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release configurations builds fine, but Debug fails. |
|
It seems that some tests has bad tags with extra closing ]] see https://github.com/search?q=repo%3Agabime%2Fspdlog+%5D%5D%22&type=code |
Yep. I will try to fix that. |
|
@gabime It works now. Thanks for the pointer. |
|
Thanks @xvitaly . Merged. |
|
@xvitaly Unfortunately the windows appveyor CI fails now. Could you please take a look? |
Typical Windows problem - missing Catch2Main.dll near spdlog-utests.exe. |
|
We need to copy compiled |
|
I will try to fix that in a separate PR. |
|
Thanks |
seker
pushed a commit
to seker/spdlog
that referenced
this pull request
Mar 3, 2023
* Added Catch v3 support. * Removed extra square brackets from some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Catch v3 support. Second attempt.