Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLM_FUNC_QUALIFIER to functors in "type_vec4.inl" #546

Merged
merged 1 commit into from
Sep 9, 2016

Conversation

taketwo
Copy link

@taketwo taketwo commented Sep 9, 2016

Functors in "type_vec4.inl" are missing GLM_FUNC_QUALIFIER. When compiled with NVCC, this results in a flood of warnings like this:

/home/sergey/third-party/glm/src/glm/detail/type_vec4.inl(418): warning: calling a __host__ function from a __host__ __device__ function is not allowed
          detected during:
            instantiation of "glm::tvec4<T, P> &glm::tvec4<T, P>::operator*=(U) [with T=float, P=glm::highp, U=float]" 
(701): here
            instantiation of "glm::tvec4<T, P> glm::operator*(const glm::tvec4<T, P> &, T) [with T=float, P=glm::highp]" 
/home/sergey/third-party/glm/src/glm/detail/func_packing.inl(76): here

for every operation involving vec4.

@Groovounet Groovounet merged commit 9f59012 into g-truc:master Sep 9, 2016
@Groovounet
Copy link
Member

Thanks for contributing!

@taketwo taketwo changed the title Add GLF_FUNC_QUALIFIER to functors in "type_vec4.inl" Add GLM_FUNC_QUALIFIER to functors in "type_vec4.inl" Sep 9, 2016
@taketwo taketwo deleted the add-glm-func-qualifier branch September 9, 2016 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants