This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Add Restaurant class - A randon Food and Beverage names generate #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in en_US and pt_BR
|
Hi, and thanks for your contribution. I suggest you publish these provider as a standalone package instead of contributing to the core. I'll be happy to link to it in Faker's README. |
|
I would like the commit to be accepted, but I followed your advice and created another repository: https://github.com/jzonta/FakerRestaurant |
|
Nice! Feel free to open a PR in Faker to add a link to your package in the README. |
|
Following the recommendations, I created the PR to add the link to the README #1374 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in en_US and pt_BR