Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about using efficient map clear with Go 1.20 as base #5569

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Feb 28, 2025

Description:

Just a quick fix to make sure we are using the fast map delete pattern instead of allocating a new map on clear. This compiles down to basically the same thing as doing clear(m.m) in Go 1.21 or later.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Feb 28, 2025

Coverage Status

coverage: 62.419% (+0.05%) from 62.372%
when pulling 3f4b9bf on Jacalz:efficient-map-clear
into e471a5a on fyne-io:develop.

@Jacalz Jacalz changed the title Use efficient map delete pattern intead of allocating new map Add comment about using efficient map clear with Go 1.20 as base Feb 28, 2025
@Jacalz Jacalz merged commit f334420 into fyne-io:develop Feb 28, 2025
11 checks passed
@Jacalz Jacalz deleted the efficient-map-clear branch February 28, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants